Opened 6 months ago
Closed 4 months ago
#31763 closed enhancement (fixed)
ManifoldSubset: New methods declare_subset, declare_superset
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  
Cc:  egourgoulhon, ghmjungmath  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  c4acd09 (Commits, GitHub, GitLab)  Commit:  c4acd094ba97380f90e4e404dd871be6c932a5da 
Dependencies:  #31736  Stopgaps: 
Description
Followup from #31736, which introduced declare_equal
.
Change History (13)
comment:1 Changed 6 months ago by
 Branch set to u/mkoeppe/manifoldsubset__new_methods_declare_subset__declare_superset
comment:2 Changed 6 months ago by
 Commit set to 0cc9eb8c4121fa054c866679e348aaae352c81a4
 Status changed from new to needs_review
comment:3 Changed 5 months ago by
Ready for review.
comment:4 Changed 5 months ago by
In the docstring of declare_superset
, the following changes should be made:
def declare_superset(self, *subsets): r"""  Declare ``self`` to be a subset of each of the given supersets. + Declare ``self`` to be a superset of each of the given subsets. INPUT:   ``supersets``  other subsets of the same manifold +  ``subsets``  other subsets of the same manifold
comment:5 Changed 5 months ago by
In the doctests of declare_subset
, the line
sage: M.declare_subset(V)
may look surprising at first glance, since it amounts to making all previously introduced subsets U1
, U2
and V
equal to the whole manifold M
. Maybe a comment should be added about this, illustrated by
sage: M.equal_subset_family() Set {M, U1, U2, V} of open subsets of the 2dimensional differentiable manifold M
comment:6 Changed 5 months ago by
 Commit changed from 0cc9eb8c4121fa054c866679e348aaae352c81a4 to 41826b46f4b46592b3ed200842b8e5f8d301f081
comment:7 Changed 5 months ago by
Good idea, done
comment:8 Changed 5 months ago by
 Reviewers set to Eric Gourgoulhon
 Status changed from needs_review to positive_review
Good to go!
comment:9 Changed 5 months ago by
Thanks for the review!
comment:10 Changed 4 months ago by
 Commit changed from 41826b46f4b46592b3ed200842b8e5f8d301f081 to 7fed9efe67eb727e1e0130807f7b76e10a4db898
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
359dde1  Merge branch 't/31727/manifoldsubset__add_methods_subset_family__superset_family__equal_subset_family__deprecate_method_list_of_subsets' into t/31732/manifoldsubset__new_methods_declare_empty__declare_nonempty__is_empty__has_defined_points__open_cover_family

fd4506a  Merge #31732

7fed9ef  Merge #31736

comment:11 Changed 4 months ago by
 Commit changed from 7fed9efe67eb727e1e0130807f7b76e10a4db898 to c4acd094ba97380f90e4e404dd871be6c932a5da
Branch pushed to git repo; I updated commit sha1. New commits:
c4acd09  Merge tag '9.4.beta2' into t/31763/manifoldsubset__new_methods_declare_subset__declare_superset

comment:12 Changed 4 months ago by
 Status changed from needs_review to positive_review
Trivial merge with latest beta
comment:13 Changed 4 months ago by
 Branch changed from u/mkoeppe/manifoldsubset__new_methods_declare_subset__declare_superset to c4acd094ba97380f90e4e404dd871be6c932a5da
 Resolution set to fixed
 Status changed from positive_review to closed
Last 10 new commits:
ManifoldSubset.{subset,superset}_digraph: New option quotient; use it for {subset,superset}_poset
ManifoldSubset.declare_equal: New
is_empty, declare_nonempty, has_defined_points: Add doc, examples
Merge #31732
ManifoldSubset.equal_subset_family: Fixup
src/sage/manifolds/{family,manifold,subset,differentiable/manifold,**/*_submanifold}.py: Update authors, copyright
ManifoldSubset.subset_digraph: Do not forget to include isolated vertices
Merge #31736
ManifoldSubset.declare_{sub,super}set: New
src/sage/manifolds/differentiable/examples/real_line.py: Use declare_subset